added merged HDF4 changes #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[nevermind, I see you just moved the code to much further down]
|
DennisHeimbigner
approved these changes
Apr 5, 2018
|
Yes thanks, I am doing this.
Also of course running various CI tests with address sanitizer.
…On Wed, Apr 4, 2018, 8:24 PM Dennis Heimbigner ***@***.***> wrote:
***@***.**** approved this pull request.
Did a quick scan and it looks good to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#922 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUr3EI70iBnnnXGfR8NJuV068DLxkm3ks5tlYB0gaJpZM4THfgU>
.
|
|
Thanks!! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accumulates changes with the HDF4 dispatch code. Changes include:
Moved some functions to libdispatch which can be used in more than one dispatch layer. Use these shared functions in the pnetcdf layer, which previously re-implemented them. The functions are also used in the external dispatch later, the AB-dispatch package.
Use of void * in INFO_T structs to hold HDF4 data. Now libsrc4 does not need to include hdf4 header files. This will also be done for HDF5 as part of Separate internal netCDF-4 data model from HDF5 code #856.
HDF4 did not used to handle data conversion correctly (see HDF4 reads do not convert type as they should #916). This PR fixes that.
As requested, all non-static functions now start with "nc" or "NC".
Long function in hdf4file.c has been broken into several functions, reducing some code repetition.
Extra test added to increase test coverage and test some previously untested features (like data conversion).
Fixes #916.
Fixes #913.
Fixes #871.
Fixes #870.
Part of #856.
Part of #177.
Once this is past review and merged, I'll present a PR with separation of HDF5 from libsrc4 (#856).