Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails due to missing LIBADD dependency #82

Closed
matzeri opened this issue Nov 29, 2019 · 1 comment · Fixed by #83
Closed

Build fails due to missing LIBADD dependency #82

matzeri opened this issue Nov 29, 2019 · 1 comment · Fixed by #83
Assignees
Milestone

Comments

@matzeri
Copy link

matzeri commented Nov 29, 2019

the below code solved the build failures on cygwin

--- origsrc/netcdf-cxx4-4.3.1/cxx4/Makefile.am  2019-09-12 20:34:58.000000000 +0200
+++ src/netcdf-cxx4-4.3.1/cxx4/Makefile.am      2019-11-29 14:49:21.929609300 +0100
@@ -13,6 +13,8 @@ lib_LTLIBRARIES = libnetcdf_c++4.la
 # http://www.gnu.org/s/libtool/manual/html_node/Updating-version-info.html
 libnetcdf_c__4_la_LDFLAGS = -version-info 2:0:1 -no-undefined

+libnetcdf_c__4_la_LIBADD = -lnetcdf
+
 # These headers will be installed in the users header directory.
 include_HEADERS = netcdf ncAtt.h ncCheck.h ncDim.h ncException.h       \
 ncGroup.h ncOpaqueType.h ncVar.h ncVlenType.h ncCompoundType.h         \
--- origsrc/netcdf-cxx4-4.3.1/plugins/Makefile.am       2019-09-12 20:34:58.000000000 +0200
+++ src/netcdf-cxx4-4.3.1/plugins/Makefile.am   2019-11-29 15:09:25.382242000 +0100
@@ -20,9 +20,11 @@ lib_LTLIBRARIES = libh5bzip2.la

 libh5bzip2_la_SOURCES = ${HDF5PLUGINSRC}
 libh5bzip2_la_LDFLAGS = -module -avoid-version -shared -export-dynamic -no-undefined
+libh5bzip2_la_LIBADD = -lhdf5

 libmisc_la_SOURCES = H5Zmisc.c H5Zutil.c h5misc.h
 libmisc_la_LDFLAGS = -module -avoid-version -shared -export-dynamic -no-undefined -rpath ${abs_builddir}
+libmisc_la_LIBADD = -lhdf5


 EXTRA_DIST=${PLUGINSRC} ${BZIP2SRC} ${PLUGINHDRS} ${BZIP2HDRS} \
@WardF WardF self-assigned this Dec 2, 2019
@WardF
Copy link
Member

WardF commented Dec 2, 2019

Thanks!

@WardF WardF added this to the 4.3.2 milestone Dec 2, 2019
WardF added a commit that referenced this issue Dec 2, 2019
@WardF WardF closed this as completed in #83 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants