Make repository usable as Git submodule #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of all CMAKE_{SOURCE|BINARY}_DIR usages in CMake scripts, in order
to make it possible to use netcdf-cxx via 'add_subdirectory' (as a Git
submodule, for example).
Signed-off-by: Pavel Kretov <firegurafiku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to attach NetCDF-C++ library to my project using Git submodule feature and CMake's
add_subdirectory, but to my surprise, this didn't work. I came to conclusion that it was caused by inconsistent use ofCMAKE_CURRENT_{SOURCE|BINARY}_DIRvariables. I made some replacements and it started working.I think I have fixed the issue, but, please, check if my commit is okay.