extend fix for issue #680 to include strided slices #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calls to nc_get_vara is always faster.
|
@shoyer - would you mind running the xarray tests on this before I merge? |
shoyer
added a commit
to pydata/xarray
that referenced
this pull request
Jun 27, 2017
|
I just started a build at https://travis-ci.org/pydata/xarray/builds/247647274, should have results in 10-15 minutes. Look for the job "py36-netcdf4-dev" |
|
The xarray test suite passes, which is encouraging but by no means definitive :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now strided slices are converted to individual calls to nc_get_vara, instead of one call to nc_get_vars. (as long as the total number of calls is less than 1000).