Latest dataset issue #118
Merged
Latest dataset issue #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a good fix to get in the next release, as the GOES-16 datasets will likely be on thredds-jumbo, which siphon cannot talk to without this fix. |
|
@dopplershift - no pytest? I'm guessing you ran into this at some point with MetPy? |
|
The build I just checked looks like a more serious protobuf problem....I can dig in more later. |
|
This will need to be rebased on master after #119 is merged, which should fix our test problems. |
|
Alright, you should be good for a rebase now. |
In TDS 4.6, the latest service had a `name` of `Latest` and a `serviceType` of `Resolver`, at least on Unidata servers. In 5.0, the name has changed to simply `Resolver`, as part of the new Standard Service feature. The name was always configurable by the server admin, so there is no need to explicitly check the `service` elements `name` attribute.
Invalid values for THREDDS Catalog Metadata are not all that importiant for the end users to see. This commit sets the log level to ERROR instead of WARNING.
|
🤘 |
dopplershift
approved these changes
Mar 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TDS 4.6, the latest service had a
nameofLatestand aserviceTypeofResolver, at least on Unidata servers. In 5.0, the name has changed to simplyResolver, as part of the new Standard Service feature. The name was always configurable by the server admin, so there is no need to explicitly check theserviceelementsnameattribute.Also in this PR is change to make invalid values for THREDDS Catalog Metadata less noisy, as they are not all that importiant for the end users to see. This second commit sets the log level to ERROR instead of WARNING.