Add string representations for catalogref and dataset #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
previously approved these changes
Nov 1, 2017
jrleeman
force-pushed
the
Improve_String_Representations
branch
from
6f3aa9c
to
302c4c6
Compare
|
Should be ready to go @dopplershift - looks like the code coverage again isn't related. |
dopplershift
requested changes
Nov 2, 2017
| @@ -312,6 +314,10 @@ def __init__(self, base_url, element_node): | |||
| href = element_node.attrib['{http://www.w3.org/1999/xlink}href'] | |||
| self.href = urljoin(base_url, href) | |||
|
|
|||
| def __str__(self): | |||
There was a problem hiding this comment.
Can you add a test for this one? That's where the coverage drop is coming from.
There was a problem hiding this comment.
I did one better - I added the test AND added a string representation for catalogs as well (with a test). That revealed that the GOES16 catalog has no name as well.
jrleeman
force-pushed
the
Improve_String_Representations
branch
from
c0f066a
to
80b8d0e
Compare
dopplershift
approved these changes
Nov 2, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make working with siphon easier for folks. closes #158