UW sounding regions #199
UW sounding regions #199
Conversation
siphon/simplewebservice/wyoming.py
Outdated
| try: | ||
| region = regions[region.lower()] | ||
| except KeyError: | ||
| raise(KeyError('Invalid region {}. Valid regions are ' |
There was a problem hiding this comment.
raise is not a function. Also, the indentation should line up with the ' in KeyError('.
siphon/simplewebservice/wyoming.py
Outdated
| region (optional) : str | ||
| Region for the sounding data. Valid regions are `North America`, | ||
| `South America`, `South Pacific`, `New Zealand`, `Antarctica`, | ||
| `Arctic`, `Europe`, `Africa`, `Southeast Asia`, `Mideast` Defaults |
There was a problem hiding this comment.
Period after Mideast. Also, should probably replace backticks with single quotes...I think.
jrleeman
force-pushed
the
UW_Sounding_Regions
branch
from
4b0dbb9
to
8dfdcbe
Compare
|
Interestingly enough, no matter what the region is, you can get data for any station anywhere. I believe this is a fluke in the web API as I verified the behavior in the browser. Selecting a region changes the map, but doesn't appear to actually limit the station search area in the database. We should probably ping Larry on this. |
jrleeman
force-pushed
the
UW_Sounding_Regions
branch
from
8dfdcbe
to
ceb653d
Compare
siphon/simplewebservice/wyoming.py
Outdated
| try: | ||
| region = regions[region.lower()] | ||
| except KeyError: | ||
| raise KeyError("Invalid region {}. Valid regions are 'North America'" |
There was a problem hiding this comment.
should probably raise a ValueError instead of KeyError, since the error is that the user passed in a bad value.
jrleeman
force-pushed
the
UW_Sounding_Regions
branch
2 times, most recently
from
d101e02
to
5989bbd
Compare
jrleeman
force-pushed
the
UW_Sounding_Regions
branch
from
5989bbd
to
1a0b21e
Compare
|
Larry says they do not use region except for the map on the website, so we don't need the ability to pass it. I've just defaulted to naconf and removed the ability to specify a region. |
jrleeman
force-pushed
the
UW_Sounding_Regions
branch
from
1a0b21e
to
3b19cec
Compare
Closes #176 and improves the region functionality. Users can specify human readable names instead of the abbreviations (which aren't listed anywhere I've found). The region will also be case insensitive. Adds a test for making sure the region is valid or a helpful
KeyErroris raised.