Upper air no data available testing #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siphon/simplewebservice/iastate.py
Outdated
| @@ -127,7 +127,7 @@ def _get_data_raw(self, time, site_id): | |||
| json_data = json.loads(resp.text) | |||
|
|
|||
| # See if the return is valid, but has no data | |||
| if not json_data['profiles'][0]['profile']: | |||
| if len(json_data['profiles'])==0 or not json_data['profiles'][0]['profile']: | |||
There was a problem hiding this comment.
if not (json_data['profiles'] and json_data['profiles'][0]['profile']):
jrleeman
force-pushed
the
No_Upperair_Data
branch
2 times, most recently
from
702bc7d
to
ad79fd6
Compare
dopplershift
reviewed
Apr 2, 2018
|
Should be good to go now. |
dopplershift
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for no data available from upper air Wyoming and Iowa. Closes #205