HTTP Client updates #242
Merged
HTTP Client updates #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dopplershift
commented
Aug 10, 2018
dopplershift
commented
- Improve message when server returns error (Fixes Better Server Error Handling #222)
- Refactor session handling so that we can set default options, including authentication. (Fixes Basic authentication #117)
Closed
dopplershift
force-pushed
the
client-updates
branch
from
7e3ac4e
to
47e9147
Compare
Make it clearer that the text is what the server returned.
This turns the collection of functions dealing with HTTP access into a class that holds the options and returns properly constructed Sessions. This allows setting up basic authentication options.
For some reason needed to make sphinx-gallery work.
dopplershift
force-pushed
the
client-updates
branch
from
47e9147
to
f9a44c3
Compare
jrleeman
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.