ENH: Add the option to return xarray from catalog helpers (Fixes #229) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrleeman
reviewed
Aug 13, 2018
siphon/catalog.py
Outdated
| import xarray as xr | ||
| provider = xr.open_dataset | ||
| except ImportError: | ||
| raise ImportError('OPENDAP access needs xarray to be installed.') |
There was a problem hiding this comment.
Should this be OPENDAP needs xarray or something specific to using the xarray accessor like 'xarray must be installed to use xarray access method.' ?
dopplershift
force-pushed
the
xarray-access
branch
from
b7ff42f
to
26f3ea3
Compare
…a#229) For OPeNDAP and CDMRemote.
dopplershift
force-pushed
the
xarray-access
branch
from
26f3ea3
to
0d09c49
Compare
jrleeman
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OPeNDAP and CDMRemote.