Fix dataset parsing for Hyrax catalogs #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way parsing is done, we look backwards (on when a dataset tag is encountered) to handle datasets with embedded access tags. Unfortunately, this left us not handling the last such dataset encountered if it contained such tags, like is done on NASA's Hyrax server.
dcamron
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Due to the way parsing is done, we look backwards (on when a dataset tag is encountered) to handle datasets with embedded access tags. Unfortunately, this left us not handling the last such dataset encountered if it contained such tags, like is done on NASA's Hyrax server.
Ping @lesserwhirls (or @haileyajohnson) in case you see a better way to handle this. Really, I'm not at all happy how we're parsing right now (stateful, flat iteration) and would really love to restructure it. Unfortunately, I don't understand all the nuanced cases, nor are those cycles available. It just seems like it would be a LOT better if we could make use of the hierarchy present in the XML.
Checklist