This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
NetcdfSubset didn't fire basic challenge when dataset is restricted #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just working on this yesterday in 4.6.0. Have you tried that branch? |
|
I haven't tried in 4.6.0. I've tried in 4.5.4 and 4.5.6 because are the versions deployed in the production server. Is that issue fixed in 4.6.0? I can test in that version in any case but it would be great to have a fix in 4.5.6. |
|
4.5 is not a stable release, probably wont backport. 4.6.1 will be stable release soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd is null when a Feature type is not supported and when a dataset is restricted if the user is not logged in. Maybe the final solution is to split the behaviour in the Dataset service throwing like an Unauthenticated exception that can be catched by the controllers. This solution mentioned requires to modify all the controllers which use FeatureDatasetService in order to catch it.
Fixes #103