This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Enforce use of shared dimensions in groups #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2015 15:52
…my warning. * Don't include a stack trace.
* Group.addDimension() and Group.addDimensionIfNotExists() methods now throw an exception if the dimension isn't shared. * NetcdfFileWriter.addDimension() methods no longer have an "isShared" parameter. Such dimensions should always be shared and allowing them to be private is confusing and error-prone. * Update client code that uses those methods. * Add notes to UpgradingTo5.adoc
|
Bump. |
cwardgar
added a commit
that referenced
this pull request
Dec 16, 2015
Enforce use of shared dimensions in groups
|
This was screwing up a new PR I was trying to do, so I went ahead and merged it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, an unrelated but too-small-for-its-own-PR commit: