Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Remove HDF5FILL control flag, take 2 (fixes #539) #544

Merged
merged 5 commits into from May 5, 2016
Merged

Conversation

cwardgar
Copy link
Contributor

@cwardgar cwardgar commented May 3, 2016

This is identical to #542 except that it is on a branch of the upstream repo, not my personal repo. So, others can work on it.

@DennisHeimbigner this commit broke 2 tests in :dap4 and I don't feel comfortable fixing them. Can you take a look?

@cwardgar
Copy link
Contributor Author

cwardgar commented May 4, 2016

I did a Jenkins run just to make sure that this doesn't break any other tests: https://jenkins-aws.unidata.ucar.edu/job/cwardgar/21/

4 new failures since last run. I suspect that only dap4.test.TestServlet.testServlet and dap4.test.TestServletConstraints.testServletConstraints are related.

Gotta love the mental exercise of concluding: "oh, those other 2 failures don't count because they're just part of those tests that fail at random sometimes".

@DennisHeimbigner
Copy link
Contributor

Gotta love the mental exercise of concluding: "oh, those other 2 failures don't count because they're
just part of those tests that fail at random sometimes
What are you talking about?

@cwardgar
Copy link
Contributor Author

cwardgar commented May 4, 2016

ucar.nc2.dt.grid.TestReadAndCountDods.readAndCount and thredds.server.ncss.controller.grid.GridAsPointDataTest.shouldGetData also failed since the last Jenkins run, but they're likely unrelated. They don't count because they often fail, either at random or because of variable external resources.

@DennisHeimbigner
Copy link
Contributor

ok, I have fixed the dap4 tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants