This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Tweak generation of ToolsUI JNLP files so they work on our web server #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui.jar's 'Codebase' manifest attribute and the /jnlp/@codebase attributes of ToolsUI JNLP files are now kept in sync. They are controlled by a single variable in ':ui': webstartCodebase. It turns out that different values for all of these codebases was the principal cause of the "Application Blocked by Java Security" failures we were seeing in javaws. * The ToolsUiJnlp tasks now have a codebase property. Updated unit tests to exercise the new property. * The aforementioned property may be 'null', which suppresses output of the /jnlp/@codebase attribute. This is useful for local Web Start testing. * Restored my (now simpler) notes about how to test Web Start locally. Other changes: * Don't include /jnlp/@href attribute in ToolsUiJnlp*Task output files. * ToolsUiJnlpExtensionTask outputs must include '<security><all-permissions/></security>' element. * Refactored ToolsUiJnlp*Task tests to be simpler and more consistent. * For all URLs in our JAR manifests and JNLP files that point to our websever, use HTTPS instead of HTTP.
|
I prepared the 4.6.10 Web Start release using this code and verified that it works. You can too. So, I'm gonna go ahead and merge this in myself, as it's blocking me from doing the rest of the 4.6.10 release. Plus, it's all Gradle and JNLP stuff anyway, which is hard for others to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui.jar's 'Codebase' manifest attribute and the
/jnlp/@codebaseattributes of ToolsUI JNLP files are now kept in sync. They are controlled by a single variable in:ui:webstartCodebase. It turns out that different values for all of these codebases was the principal cause of the "Application Blocked by Java Security" failures we were seeing in javaws.codebaseproperty. Updated unit tests to exercise the new property.null, which suppresses output of the/jnlp/@codebaseattribute. This is useful for local Web Start testing.Other changes:
/jnlp/@hrefattribute inToolsUiJnlp*Taskoutput files.ToolsUiJnlpExtensionTaskoutputs must include<security><all-permissions/></security>element.ToolsUiJnlp*Tasktests to be simpler and more consistent.