Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag for Java 17/Tomcat 10? #109

Closed
srstsavage opened this issue Oct 5, 2022 · 4 comments
Closed

Tag for Java 17/Tomcat 10? #109

srstsavage opened this issue Oct 5, 2022 · 4 comments

Comments

@srstsavage
Copy link
Contributor

As of v2.19, ERDDAP requires Java 17 and Tomcat 10.

https://coastwatch.pfeg.noaa.gov/erddap/download/changes.html#changes2.19

https://github.com/axiom-data-science/docker-erddap uses tomcat-docker as the base image, so I'm investigating the appetite for cultivating a unidata/tomcat-docker:10-jdk17-openjdk release based on tomcat:10-jdk17.

Is the willingness to include this variant? Would it become the latest branch? etc

@julienchastang
Copy link
Member

It seems like this could exist in parallel to the current branches. latest may stay as it is though. (ping @robertej09 )

@ana-v-espinoza
Copy link
Contributor

Agreed with Julien. We can add a new branch to this repo that's based on tomcat:10-jdk17. Will see about getting to this next week.

@srstsavage
Copy link
Contributor Author

One note, tomcat:10-jdk17 is based on Ubuntu Jammy and is incompatible with older Docker engines.

docker-library/tomcat#269

So, we may want to offer a variant based on 10.0-jdk17-temurin-focal as well (I verified that it's compatible with older engines). Only difference should be in the FROM line for the base image.

ana-v-espinoza added a commit that referenced this issue Nov 14, 2022
@ana-v-espinoza
Copy link
Contributor

Closed by #112

This was referenced Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants