Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize the framework we have #9

Closed
Unihedro opened this issue Nov 9, 2014 · 2 comments
Closed

Modularize the framework we have #9

Unihedro opened this issue Nov 9, 2014 · 2 comments

Comments

@Unihedro
Copy link
Owner

Unihedro commented Nov 9, 2014

Our code is very messy at the moment. AbstractBot holds both the message queue and manages the listeners, while the code that handles the connection is spread everywhere. Reliable development is hindered, so I propose that we take some time to fix up the spaghetti code and improve the object-oriented design of JavaBot, bearing in mind the following concepts from SOLID:

  • Single responsibility
  • Open/closed
  • Liskov substitution
  • Interface segregation
  • Dependency inversion

Yeah... That's all I have to say for now.

@Vogel612
Copy link
Collaborator

Would love to get a review on 6580df1 in reference to the decoupling (and the JavaDoc I wrote). I personally think it's fine that a Bot manages a messageQueue and his own listeners. Anything else would require moving the MessageListener functionality into a Bot itself.

@Vogel612
Copy link
Collaborator

Closing this issue, since pull-request #16 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants