You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our code is very messy at the moment. AbstractBot holds both the message queue and manages the listeners, while the code that handles the connection is spread everywhere. Reliable development is hindered, so I propose that we take some time to fix up the spaghetti code and improve the object-oriented design of JavaBot, bearing in mind the following concepts from SOLID:
Single responsibility
Open/closed
Liskov substitution
Interface segregation
Dependency inversion
Yeah... That's all I have to say for now.
The text was updated successfully, but these errors were encountered:
Would love to get a review on 6580df1 in reference to the decoupling (and the JavaDoc I wrote). I personally think it's fine that a Bot manages a messageQueue and his own listeners. Anything else would require moving the MessageListener functionality into a Bot itself.
Our code is very messy at the moment.
AbstractBot
holds both the message queue and manages the listeners, while the code that handles the connection is spread everywhere. Reliable development is hindered, so I propose that we take some time to fix up the spaghetti code and improve the object-oriented design of JavaBot, bearing in mind the following concepts from SOLID:Yeah... That's all I have to say for now.
The text was updated successfully, but these errors were encountered: