23 chat handle changes #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir declarations where possible, also created a help-command and renamed the old help to about fixes #23
…against Errors when executing commands, improved help-command to return properly when invoked without parameters, Cleaned up replying and failure-information in eval-command
…ing simple responses upon certain conditions
Marked old CommandHandle.Builder constructor as Deprecated and removed all calls to it. Adjusted CommandCalling procedure to properly call commands by their names. Commands are now responsible for incorrect input. Commandname matching is case-insensitive for now. Also disallowed overriding enqueueMessage functionality for Bots, to guarantee functionality
- Extracted simple commands to a CoreBotCommands utility class - set more focus on Constructor of Program to allow better granulation of startup process - completely removed ScriptRunner from Program's responsibility
Moved the already existing preset static command-provider classes into commands.sets package for centralized organization
- ChatInterface now extends AutoCloseable, having a default-method for backwards compatibility - StackExchangeChat now overrides AutoCloseable#close - Deprecated CommandHandle.Builder constructor is now unused, warning is suppressed - ChatCommands now follow new Builder syntax - ScriptRunnerCommands now follow new Builder syntax - PrintUtilTest no more prints to System.out - Minor javadoc changes - Rolled back space vs. tab padding change in DefaultBot - Program no longer holds an instance of scriptRunner
Vogel612
added a commit
that referenced
this pull request
Jan 9, 2015
Chat handle changes: - Deprecated Predicate - Calling commands by name now - ChatInterface is now AutoCloseable - Created Bot to interact upon Predicate<String> - Refactorings to Program and preset ChatHandles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23 and also references #9 in a way.