Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy unreleased notes to changelog #563

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

podliashanyk
Copy link
Contributor

In some PRs changelog entries were forgotten to be updated (only notes were updated instead). This PR makes chengelog more up to date.
As mentioned in #559:

Before it is done, some entries need to be manually moved from NOTES to CHANGELOG. This is because in the following PRs for some reason I have only updated the NOTES file (which further proves that keeping both files can easily lead to confusion when contributing):

@podliashanyk podliashanyk added the documentation Improvements or additions to documentation label Apr 22, 2024
@podliashanyk podliashanyk requested a review from hmpf April 22, 2024 11:48
@podliashanyk podliashanyk self-assigned this Apr 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (c97acf1) to head (80e708e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          86       86           
  Lines        3692     3692           
  Branches      837      839    +2     
=======================================
  Hits         2117     2117           
  Misses       1566     1566           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1 @@
_Incident ID in \<its source system\>_ field to incident details view, which displays ID by which incident is referenced internally in its source system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this is saying but it's text and we're in a hurry so ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should have been added instead of changed entry. Merge conflict side effect I would guess. But as you said, we are in a hurry 😅

@podliashanyk podliashanyk merged commit 33298e5 into master Apr 22, 2024
4 checks passed
@podliashanyk podliashanyk deleted the copy-unreleased-notes-to-changelog branch April 22, 2024 11:57
@podliashanyk podliashanyk mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants