Improvements in Notification Profile view and close issues,. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgenbele
commented
Jul 1, 2020
•
jorgenbele
commented
- Change defaults for new profiles
- Fix problems when connection to backend is down/action fails.
- Fix problem where available timeslots doesn't update correctly when a profile is deleted.
- Update index.html and manifest.json to display Argus instead of "React App" or equivalent.
jorgenbele
commented
Jul 1, 2020
At some point someone added the `react-table.css` stylesheet to `public/index.html`, but linked it to the stylesheet from node_modules/. This hack is no longer needed because it is imported in the React components that use it. This closes Uninett#83.
Previously it just took the first timeslot in the list without taking into consideration if it was available or not.
Attach a revision number to the representation of profiles in `components/profilelist/ProfileList.tsx` such that when we successfully make a change it replace the old component instance entirely.
|
I'm just merging it now. Any discussions on what the title and such should be can be done in the original issues/new issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.