Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detail URL should be fully qualified, since it points to the source's UI #50

Closed
hmpf opened this issue Jun 12, 2020 · 5 comments · Fixed by #161
Closed

Detail URL should be fully qualified, since it points to the source's UI #50

hmpf opened this issue Jun 12, 2020 · 5 comments · Fixed by #161
Projects
Argus Sprint #3
Milestone
Version 1.0

Comments

@hmpf
Copy link
Contributor

hmpf commented Jun 12, 2020

Closes #42
This was referenced Jun 12, 2020
Closed
Closed
@hmpf hmpf changed the title Detail URL should be fqdn since it points to the source's view Detail URL should be fqdn since it points to the source's UI Jun 12, 2020
@lunkwill42
Copy link
Member

How is this not covered by #40 ?

@hmpf hmpf mentioned this issue Jun 12, 2020
Closed
@hmpf
Copy link
Contributor Author

hmpf commented Jun 12, 2020

#40 is one possible way of solving it, yes.

@hmpf hmpf mentioned this issue Jun 17, 2020
Closed
@hmpf
Copy link
Contributor Author

hmpf commented Jun 17, 2020

Going by #40, should the full url be sent to the frontend, or should the frontend join the pieces itself?

@lunkwill42 lunkwill42 changed the title Detail URL should be fqdn since it points to the source's UI Detail URL should be fully qualified, since it points to the source's UI Jun 23, 2020
@lunkwill42
Copy link
Member

Going by #40, should the full url be sent to the frontend, or should the frontend join the pieces itself?

IMHO, the backend API should probably piece together a full URL from relative URLs contained within an alert. This makes consumption/reading of the API much easier (one shouldn't necessarily need all the registration details of an AlertSource to interpret Alert data).

@hmpf hmpf added this to the Version 1 milestone Sep 23, 2020
@hmpf hmpf added this to In progress in Argus Sprint #3 Sep 23, 2020
@hmpf
Copy link
Contributor Author

hmpf commented Sep 24, 2020 •
edited

Detail url in frontend should be fully qualified if possible, so will change the backend api to join source.base_url and incident.details_url.

@hmpf hmpf closed this as completed Sep 24, 2020
Argus Sprint #3 automation moved this from In progress to Done Sep 24, 2020
@hmpf hmpf reopened this Sep 24, 2020
Argus Sprint #3 automation moved this from Done to In progress Sep 24, 2020
@hmpf hmpf moved this from In progress to Blocked in Argus Sprint #3 Sep 25, 2020
This was referenced Sep 25, 2020
Merged
Closed
@hmpf hmpf closed this as completed in #161 Sep 25, 2020
Argus Sprint #3 automation moved this from Blocked to Done Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Argus Sprint #3
  
Done
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Merge details_url with source's base_url, if any hmpf/Argus
2 participants
@lunkwill42 @hmpf