Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make detail view of an alert work #42

Closed
hmpf opened this issue Jun 10, 2020 · 3 comments
Closed

Make detail view of an alert work #42

hmpf opened this issue Jun 10, 2020 · 3 comments

Comments

@hmpf
Copy link
Contributor

hmpf commented Jun 10, 2020

Clicking on the link to more details currently:

  1. uses an unsupported url.
  2. sends you to the API and needs a token in the header
@lunkwill42
Copy link
Member

lunkwill42 commented Jun 12, 2020

This is a misunderstanding. The details URL is used verbatim from the alert record posted to the API. This is intended to be a hyperlink back to the source system to explore the alert details. However, the example data uses relative links within the source system, which become useless inside AAS without a base FQDN/URL to prepend. See #40.

(In other words, the API urls you are referring to are not really AAS URLs at all, they are just the verbatim relative NAV API urls used in the example data)

I'd vote to close this and keep #40.

@lunkwill42
Copy link
Member

... with the addendum that displaying the hyperlink text is pretty useless. I'd rather skip the entire column, and hyperlink the name of the source system in the source column instead.

@hmpf
Copy link
Contributor Author

hmpf commented Jun 12, 2020

See #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants