Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a model and API for Acknowledgements #72

Closed
lunkwill42 opened this issue Jul 2, 2020 · 0 comments · Fixed by #124
Closed

Implement a model and API for Acknowledgements #72

lunkwill42 opened this issue Jul 2, 2020 · 0 comments · Fixed by #124
Assignees
Labels
data model Affects the data model and/or SQL schema discussion Requires developer feedback/discussion before implementation

Comments

@lunkwill42
Copy link
Member

Incidents can be Acknowledged, primarily by end users of Argus.

Semantically, an Acknowledgment is a way for a user to comment on an Incident, signalling, for example, to other users that this Incident has the attention of someone, and something is being done about it.

Functionally, in a normal list of active/open Incidents, Incidents that have an active acknowledgment should be suppressed. I.e. an API endpoint that returns a list of active Incident objects, should remove acknowledged Incidents from the list, unless specifically instructed to keep them in the result (by way of a GET parameter).

Multiple acknowledgements can be created on an Incident.

A ack model should contain:

  • A relation to an Incident
  • A relation to the User that made the acknowledgement
  • A timestamp for when the acknowledment was made.
  • A message string, entered by the acknowledging user.
  • An optional expiry time.

For the purposes of filtering (as mentioned above), an Incident should be considered acknowledged when there is at least one non-expired Acknowledgement object associated with it.

@lunkwill42 lunkwill42 added the discussion Requires developer feedback/discussion before implementation label Jul 2, 2020
@lunkwill42 lunkwill42 changed the title Implement a model for Acknowledgements Implement a model and API for Acknowledgements Jul 2, 2020
@lunkwill42 lunkwill42 added this to To do in Argus Sprint #2 via automation Jul 2, 2020
@ddabble ddabble added the data model Affects the data model and/or SQL schema label Aug 10, 2020
@ddabble ddabble self-assigned this Aug 11, 2020
@ddabble ddabble moved this from To do to In progress in Argus Sprint #2 Aug 11, 2020
@hmpf hmpf closed this as completed in #124 Aug 19, 2020
Argus Sprint #2 automation moved this from In progress to Done Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model Affects the data model and/or SQL schema discussion Requires developer feedback/discussion before implementation
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants