Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-admin users apparently have no access to receive alerts by default #1731

Open
lunkwill42 opened this issue Jun 5, 2018 · 0 comments
Open
Labels

Comments

@lunkwill42
Copy link
Member

lunkwill42 commented Jun 5, 2018

I was somewhat surprised to find, during debugging a related problem, that it appears NAV (4.8) does not by default allow non-admin users permission to receive any kind of alert.

In fact, the baseline SQL schema grants permissions to receive G01: All alerts to the NAV Administrators group only - and, this permission can, in fact, be revoked.

This appears to have been the case since the very first version of NAV with the Alert Profiles and alertengine components in it. I don't think it is a very sane default, and is bound to confuse some users - yet, I don't think it would be wise to unexpectedly add this permission to Authenticated users during an upgrade - as some user's may have come accustomed to this setting.

I propose that we, perhaps, do these things:

  1. Ensure that permissions cannot be revoked from the admins (e.g. anywhere else in NAV where the involved subject of a permissions check is an admin, permission is granted directly by the code without consulting the actual grants in the database)
  2. Grant G01: All alerts to the Authenticated users group in the SQL baseline, but not in an upgrade script.
  3. Make note of this fact in the release notes.
@lunkwill42 lunkwill42 added the bug label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant