Add BGP monitoring to NAV #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now, we're just debug logging what we collect
thus helping to reduce the number of necessary SQL queries for updates.
device and netbox aren't really required attributes of an event, so don't require them in the API. also, allow for exceptions from start_type and end_type in individual alerts. Lastly, correctly use end_type when posting end alerts, not start type.
The generic description belongs in the left column, so it can be replaced by implementing an alert specific template. Also made display of acknowledgement comment a bit more intuitive to read.
(BGP4Mib.ROOT): indicate which object represents the root of the MIB, used for testing whether any kind of contents are available from the given MIB.
this is Juniper's implementation, into its own enterprise tree, of draft 3 of the BGP4-V2-MIB, which was never standardized by an IETF RFC.
… InetAddress values
Also, hold back bgpDown alerts if the peer is known to NAV and is currently down - if alerting on iBGP sessions, you would have a bgpDown alert for every router in your mesh that is peering with a router that goes down.
|
Why not add this under the services tab for each device, and class BGP, OSPF, IS-IS etc as a service? |
|
We could potentially put it on the Services tab in ipdevinfo, but it would mostly be to avoid "tab-itis". NAV has a separate concept of service monitoring, for which this tab is usually reserved. We'll have to think about it a bit, @Justmeccsn - but I just made #1718 for that purpose - so if you have further suggestions, please put them there :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my initial attempt at implementing #1183 - BGP monitoring.
One thing remains: Add an UI for displaying known BGP sessions for each router. I would add it to
ipdevinfo, but I'm afraid of tab overload, so I think @jmbredal is best suited to do something about this. I have added a BGP report, but I do not think this will be sufficient in the long run.