Add PortAdmin "Write mem" support for H3C switches #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 1, 2017 11:12
This enables setting multiple varbinds in a single request
lunkwill42
changed the title
lunkwill42
requested changes
Jun 1, 2017
There was a problem hiding this comment.
I've done a very cursory write-test from PortAdmin (not on an H3C, though). Have not tested Arnold. Since both subsystems using SNMP SET operations are in your hands, I guess you are best qualified to assess any effects on these. I will assume read functionality is unaffected by this.
My only comment is therefore about the slight API change, noted inline.
python/nav/Snmp/pynetsnmp.py
Outdated
| (TYPEMAP.keys(), data_type)) | ||
| return value_type | ||
|
|
||
| def set(self, query, data_type, value): |
There was a problem hiding this comment.
Although a variable named type is generally a no-no, this is part of the API, and making the API inconsistent is a bigger no-no.
Either keep type, or rename it to data_type in the set method of all the other class Snmp implementations - and ensure that any calling code that is using keyword arguments is updated.
lunkwill42
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #1411