Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting netbox in background with navclean #1542

Merged
merged 4 commits into from Aug 8, 2017

Conversation

bflugon
Copy link
Contributor

@bflugon bflugon commented Jul 28, 2017

This change makes the deletion of netbox be done in the background, so that the user do not need to busy-wait for it. A cronjob for deleting netboxes every 5 minutes has also been added.

Should fix #1313

The deletion of netbox is now done by navclean, by checking the column updated by pre_delete_operation.
@lunkwill42 lunkwill42 self-requested a review August 7, 2017 07:29
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but I realize now that we need a followup on this. Since netboxes are now deleted only in 5 minute intervals, there should be some indicator in other parts of the interface that the device has been scheduled for deletion.

Something like a big red mark next to it, or using a strikethrough on the device name etc. @jmbredal can likely make some good suggestions here....

There's also the question of what happens when deleting a netbox takes more than 5 minutes - what happens to the next navclean process?

@lunkwill42
Copy link
Member

To clarify: A followup for the interface bits deserve a PR of its own. But I would like you to test what happens when the delete takes more than 5 minutes - maybe introducing an artificial delay is better than inserting millions of cam rows....

@lunkwill42 lunkwill42 self-assigned this Aug 7, 2017
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@lunkwill42 lunkwill42 merged commit f55ee83 into Uninett:master Aug 8, 2017
@lunkwill42 lunkwill42 added this to the 4.8.0 milestone Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a netbox is extremely slow
2 participants