Make sensors relatable to interfaces #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_mib mibretriver
…entity_sensors_mib
This adds a list of sensors to the port details page Linking sensors to interfaces supported for entity_sensors mib and cisco_entity_sensors_mib
lunkwill42
requested changes
Sep 4, 2017
sql/changes/sc.04.08.0510.sql
Outdated
| @@ -0,0 +1 @@ | |||
| ALTER TABLE sensor ADD COLUMN interfaceid INTEGER REFERENCES interface; | |||
There was a problem hiding this comment.
May I suggest a ON DELETE SET NULL ON UPDATE CASCADE as part of this definition? Otherwise, interface deletion would not be possible until sensors had been removed.
…base As suggested by Morten Brekkevold
|
Updated according to comments |
lunkwill42
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1211
Dependes on #1557