Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deleting non-required schemas in search_path #1568

Merged
merged 2 commits into from Aug 30, 2017

Conversation

bflugon
Copy link
Contributor

@bflugon bflugon commented Aug 24, 2017

Fixes so that pgsync correctly inserts existing non-required schemas to the search_path

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but the tests are failing for some not-very-obvious reason...

@lunkwill42 lunkwill42 merged commit b9a9186 into Uninett:4.7.x Aug 30, 2017
@lunkwill42
Copy link
Member

I did find the reason after all, the qualification of the namespace of the table auditlog_logentry had a syntax problem:

CREATE TABLE "manage.auditlog_logentry" ...

would create a table in the public namespace with the full name manage.auditlog_logentry. The correct syntax would be:

CREATE TABLE "manage"."auditlog_logentry" ...

Though I can see why this was confusing. This changescript was obviously autogenerated by @hmpf , as we don't usually quote names that don't need quoting, so our experience with the quoting rules of PostgreSQL is limited :-D

@lunkwill42 lunkwill42 added this to the 4.7.2 milestone Aug 30, 2017
@lunkwill42 lunkwill42 self-assigned this Aug 30, 2017
@lunkwill42 lunkwill42 added the bug label Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants