Remove django-oauth2-provider library dependency #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know, nav does not actually do anything oauth related. Maybe better to just call it |
|
As far as I know, nav does not actually do anything oauth related. Maybe
better to just call it `auth_token`?
Why not. I think @jmbredal was gleaning sideways at OAuth as he was
implementing the API, and then this library was pulled in for this one
tiny usage...
|
…omething more generic
jmbredal
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency to the external library, which is now non-maintained for several years.
The function may ideally be replaced in the future by something using the
secretsmodule to generate the token.