SQL baseline cleanup #1614
Merged
SQL baseline cleanup #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
although, this entire table seems to be obsolete ny now
|
I guess this is done now, you may take a quick look before we merge, @jmbredal |
jmbredal
reviewed
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bad job of reviewing #1544 - as it turns out, even though the new baseline passes the "diff test", the actual implementation is quite messy - altering table definitions after the fact, and trying to clean up data that just isn't there, since the baseline always represents a clean install.
It seems all the mess stems from uncritically copy+pasting change scripts into the baseline, without actually consolidating the changes they represent with the existing definitions.
So, this is basically a work-in-progress to clean up the results of #1544, so we can have a proper implementation of #1510.