Upgrade Django Rest Framework #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incomplete list of things that have changed in `response.data`:
* Returns a list (ReturnList) not a `dict('results', [results])`
* Returns an iso-formatted string instead of a `datetime` for dates
added 9 commits
April 26, 2018 13:54
This creates one test for each endpoint which is better than one assert for each endpoint.
No hardcoding plx
jmbredal
changed the title
hmpf
reviewed
May 3, 2018
| @@ -652,6 +653,26 @@ def get_times(request): | |||
| return starttime, endtime | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nice, moving code to where it belongs
hmpf
approved these changes
May 3, 2018
lunkwill42
requested changes
May 8, 2018
| from .models import LogEntry | ||
|
|
||
|
|
||
| class LGFKRelatedField(serializers.RelatedField): |
There was a problem hiding this comment.
I know LegacyGenericForeignKeyRelatedField is a long type, but I don't appreciate this type of mysterious abbreviations. Its only redeeming factor is that the scope is short: It's only used in the next class...
Closed
lunkwill42
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Django Rest Framework to at least support Django 1.8
As tests are passing now I consider this complete. For the reviewers - verify model-changes and take a look at the tests to see if they are sane.