No warnings for Django 1.8 #1752
Conversation
| # Django >= 1.8 | ||
| from django.apps import apps | ||
| get_models = apps.get_models | ||
| del apps | ||
| except ImportError: | ||
| # Django < 1.9 |
There was a problem hiding this comment.
I don't get the logic of these comments. The first branch is for Django >= 1.8, the exception is for Django < 1.9. So both branches include Django 1.8?
There was a problem hiding this comment.
1.8 is the first version where the new method works, and the last method where the old method works :)
There was a problem hiding this comment.
Ok, that clears things up, thanks! 👍
| from django.db.models import get_models | ||
|
|
||
| try: | ||
| # Django >= 1.8 |
There was a problem hiding this comment.
Same question about the version "requirements" given in these comments.
There was a problem hiding this comment.
Same reason as the previous case: 1.8 is the first version where the new method works, and the last method where the old method works. In 1.7 I think there is a warning to this effect.
IIRC we used to use the old method also on 1.8 but I switched the order so that we always prefer the new method whenever possible.
| try: | ||
| return connection.ops.value_to_db_datetime(value) # <= 1.8 | ||
| except AttributeError: | ||
| return connection.ops.adapt_datetimefield_value(value) # >= 1.9 |
There was a problem hiding this comment.
Interestingly enough, this appears to be a no-op for the postgresql backend in Django 1.9. This function just returns its input unchanged :)
This PR gets rid of the remaining warnings for running NAV on Django 1.8, in code that we control.