Fix broken serial numbers for Juniper, APC PowerNet and old HP devices #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - The get_serial_number API is expected to return a string, not a bytes object. - These MibRetriever implementations used the get_next() call directly. This call is not imbued with knowledge about which response OIDs can be considered text and which cannot, so all strings are essentially returned as bytes. - This caused serial numbers for all old HP switches, all Juniper equipment and PowerNET PDU's to appear as b'real-serial-num' in NAV.
hmpf
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the shift to Python 3, lots of collected serial numbers would now appear as
b'actual-serial-number'in NAV, particularly for Juniper device, APC PDUs and older HP switches.Table-based MIB object retrieval will compensate for this by recognizing retrieved columns that have a syntax equivalent to
DisplayString, converting these bytestrings on the fly to Python strings.However, the methods used to retrieve serial numbers for these devices/vendors used a more low-level SNMP call, which is not imbued with MIB object syntax knowledge, and hence did not attempt to translate the result values to actual strings.