Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SeedDB room listing queries #2400

Merged
merged 1 commit into from May 4, 2022

Conversation

johannaengland
Copy link
Contributor

Similar to #2384 in regards to #2156 this PR optimizes the room listing queries of SeedDB.

@johannaengland johannaengland self-assigned this May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2400 (5dde2f0) into master (31d59e6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   52.55%   52.55%           
=======================================
  Files         552      552           
  Lines       40152    40152           
=======================================
  Hits        21100    21100           
  Misses      19052    19052           
Impacted Files Coverage Δ
python/nav/web/seeddb/page/room.py 58.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d59e6...5dde2f0. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 3, 2022

Test results

     12 files       12 suites   11m 26s ⏱️
3 077 tests 2 981 ✔️   96 💤 0
8 706 runs  8 418 ✔️ 288 💤 0

Results for commit 5dde2f0.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on! :)

@lunkwill42 lunkwill42 added this to the 5.4.0 milestone May 4, 2022
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on! :-)

@johannaengland johannaengland merged commit e2ccc13 into Uninett:master May 4, 2022
@johannaengland johannaengland deleted the seeddb-room branch May 4, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants