Update zoom correctly when requesting link to this configuration #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an exact copy of #2469 aimed to fix the problem with the CLA |
Before, zoom value was ignored in view, but was present in the url, when user requested a link to current configuration. This commit makes zoomToBound() apply changes to zoom, when parameters are present. Parameters are present if the url with zoom, lon, lat values is present, ie when user requests link to current configuration.
lunkwill42
force-pushed
the
fix-geomap-zoom-bug
branch
from
1bbd660
to
c1e24f0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lunkwill42
approved these changes
Nov 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
- Coverage 52.99% 52.96% -0.04%
==========================================
Files 554 554
Lines 40266 40266
==========================================
- Hits 21339 21326 -13
- Misses 18927 18940 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Function zoomToBounds() updates zoom correctly in accordance with the parameters it receives. This applies to several use cases, and specifically to a scenario when user requests a link to the current configuration.
Before, zoom value was ignored in view, but was present in the url, when user requested a link to current configuration. This commit makes zoomToBound() apply changes to zoom, when parameters are present. Parameters are present if the url with zoom, lon, lat values is present, ie when user requests link to current configuration.
Closes #2412