Fix registering device error with empty comment #2580
Conversation
johannaengland
force-pushed
the
device-error-event-field-error
branch
2 times, most recently
from
451bce4
to
b9dc0c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
+ Coverage 53.75% 54.03% +0.28%
==========================================
Files 558 558
Lines 40588 40588
==========================================
+ Hits 21819 21933 +114
+ Misses 18769 18655 -114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Looks good to me!
Older versions of Django were very lenient about what you could put into select_related calls (i.e. anything was allowed, only the arguments that represented real relations were adhered to). Django changed this, and it became an error to ask for unknown relations.
This just shows that we have no automated tests that revealed this at the time Django was upgraded.
The follow-up challenge, of course, is to add a test that reveals the problem by exercising this code :-)
johannaengland
force-pushed
the
device-error-event-field-error
branch
from
1d977c0
to
af9a9e9
Compare
The netbox attribute of module is accessed in the template
johannaengland
force-pushed
the
device-error-event-field-error
branch
from
af9a9e9
to
6cee026
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Closes #2579