Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show help text when running nav command without arguments #2603

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #2601.

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2603 (bc4c2cf) into 5.6.x (cbfc888) will not change coverage.
The diff coverage is n/a.

❗ Current head bc4c2cf differs from pull request most recent head ee2baf5. Consider uploading reports for the commit ee2baf5 to get more accurate results

@@           Coverage Diff           @@
##            5.6.x    #2603   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files         558      558           
  Lines       40612    40612           
=======================================
  Hits        21887    21887           
  Misses      18725    18725           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

Test results

     12 files       12 suites   11m 52s ⏱️
3 222 tests 3 126 ✔️   96 💤 0
9 141 runs  8 853 ✔️ 288 💤 0

Results for commit ee2baf5.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland linked an issue Mar 27, 2023 that may be closed by this pull request
lunkwill42
lunkwill42 previously approved these changes Mar 31, 2023
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍

@johannaengland johannaengland merged commit b7190b9 into Uninett:5.6.x Mar 31, 2023
12 checks passed
@johannaengland johannaengland deleted the bugfix/nav-command-no-arguments branch March 31, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] the nav command crashes when run without arguments
2 participants