Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install epollreactor2 in ipdevpolld if running system is Linux #2604

Merged

Conversation

johannaengland
Copy link
Contributor

Fixes #2503.

@johannaengland johannaengland self-assigned this Mar 30, 2023
@johannaengland johannaengland changed the base branch from master to 5.6.x March 30, 2023 11:44
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Test results

     12 files       12 suites   11m 45s ⏱️
3 223 tests 3 127 ✔️   96 💤 0
9 144 runs  8 856 ✔️ 288 💤 0

Results for commit eaff20c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2604 (868c32b) into 5.6.x (479669d) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 868c32b differs from pull request most recent head eaff20c. Consider uploading reports for the commit eaff20c to get more accurate results

@@            Coverage Diff             @@
##            5.6.x    #2604      +/-   ##
==========================================
- Coverage   53.99%   53.96%   -0.04%     
==========================================
  Files         558      558              
  Lines       40621    40621              
==========================================
- Hits        21934    21921      -13     
- Misses      18687    18700      +13     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy. Only nitpick is the changelog, not the patch :)

CHANGELOG.md Outdated Show resolved Hide resolved
hmpf
hmpf previously approved these changes Apr 13, 2023
lunkwill42
lunkwill42 previously approved these changes Apr 14, 2023
lunkwill42
lunkwill42 previously approved these changes Apr 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johannaengland johannaengland merged commit 200297a into Uninett:5.6.x May 24, 2023
11 of 12 checks passed
@johannaengland johannaengland deleted the bugfix/ipdevpolld-freebsd branch May 24, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipdevpolld on FreeBSD does not work
3 participants