Never restore stale tox environment caches in GitHub workflows #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installed dependencies in tox environments are no longer automatically synced using pip-tools, which means they do not update if they are stale. We should therefore never use prefix matching for the cache Action for the tox environments, or we will end up restoring a stale environment every time the requirements files change. This ensures we only restore tox environments when the cache key matches exactly - meaning that all the tox environments should be rebuilt if any of the requirements files changed.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
=======================================
Coverage 54.20% 54.20%
=======================================
Files 558 558
Lines 40627 40627
=======================================
Hits 22020 22020
Misses 18607 18607 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
johannaengland
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installed dependencies in tox environments are no longer automatically synced using pip-tools, which means they do not update if they are stale.
We should therefore never use prefix matching for the cache Action for the tox environments, or we will end up restoring a stale environment every time the requirements files change.
This ensures we only restore tox environments when the cache key matches exactly - meaning that all the tox environments should be rebuilt if any of the requirements files changed.