Run development web server in insecure mode #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
approved these changes
May 25, 2023
The development web container doesn't work properly if `DJANGO_DEBUG=False` is set in `nav.conf`, since the staticfiles app would not serve most static resources in that case. This would prevent us from seeing what a non-debug site looks like while developing.
lunkwill42
force-pushed
the
devfix/runserver-insecure
branch
from
d8aeb60
to
608d9b3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Yup, whitenoise is great, but won't we have to run the |
Codecov Report
@@ Coverage Diff @@
## 5.6.x #2625 +/- ##
==========================================
+ Coverage 0 53.99% +53.99%
==========================================
Files 0 558 +558
Lines 0 40621 +40621
==========================================
+ Hits 0 21934 +21934
- Misses 0 18687 +18687 see 558 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development web container doesn't work properly if
DJANGO_DEBUG=Falseis set innav.conf, since the staticfiles app would not serve most static resources in that case. This would prevent us from seeing what a non-debug site looks like while developing.