Improve ipdevpoll logging of SQL queries and from Twisted library #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to debug log the db module *without* getting drowned in generated SQL queries is hard. Making a sub-logger at least enables us to deselect debug logging of queries wile debug logging everything else from nav.ipdevpoll.db
The Twisted library doesn't use the regular Python logging framework. However, a twisted log observer can be added to propagate twisted log messages to the regular python logging framework, which is what the rest of ipdevpoll process uses.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2640 +/- ##
=======================================
Coverage 54.61% 54.61%
=======================================
Files 560 560
Lines 40708 40712 +4
=======================================
+ Hits 22231 22235 +4
Misses 18477 18477
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
johannaengland
approved these changes
Jun 13, 2023
Yeah, I think I'm going to let that one slip 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on #1073, some needs for improved logging in ipdevpoll appeared. These were extracted as a separate PR to make for a smaller review :)