Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case in DNS forwards lookup results #2650

Merged
merged 2 commits into from Aug 8, 2023

Conversation

johannaengland
Copy link
Contributor

Closes #2615.

hmpf
hmpf previously approved these changes Aug 7, 2023
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr hiss black, otherwise ok.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2650 (9df36cb) into master (3775a46) will increase coverage by 0.64%.
Report is 151 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   53.99%   54.63%   +0.64%     
==========================================
  Files         558      560       +2     
  Lines       40621    40712      +91     
==========================================
+ Hits        21934    22244     +310     
+ Misses      18687    18468     -219     
Files Changed Coverage Δ
python/nav/asyncdns.py 83.90% <100.00%> (+10.34%) ⬆️

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test results

     12 files       12 suites   11m 57s ⏱️
3 165 tests 3 165 ✔️ 0 💤 0
8 970 runs  8 970 ✔️ 0 💤 0

Results for commit 9df36cb.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland changed the base branch from master to 5.6.x August 7, 2023 13:33
@johannaengland johannaengland dismissed hmpf’s stale review August 7, 2023 13:33

The base branch was changed.

@johannaengland johannaengland merged commit 2a5a975 into Uninett:5.6.x Aug 8, 2023
13 checks passed
@johannaengland johannaengland deleted the bugfix/dns-lookup-case branch August 8, 2023 07:47
@lunkwill42
Copy link
Member

Grr hiss black, otherwise ok.

Yeah, this is pretty strange, @hmpf, because we have this:

skip-string-normalization=true

Which tells me that Johanna's Black isn't correctly reading its config from this file...

@johannaengland
Copy link
Contributor Author

Very strange indeed, because I thought it might be a problem with "Format on save" in VSCode and tried to replicate it just now, but I couldn't... I will be paying more attention to this in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants