Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log refusing to send alerts to addresses of blacklisted types as debug instead of warning #2652

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Aug 8, 2023

One log entry is created for each alert every 30 seconds. The debug level is changed to debug since no new error is discovered, since we already have set the address type to blacklisted.

Closes #1787.

One log entry is created for each alert every 30 seconds
It is changed to debug since no new error is discovered
@johannaengland johannaengland self-assigned this Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Test results

     12 files       12 suites   10m 43s ⏱️
3 230 tests 3 134 ✔️   96 💤 0
9 165 runs  8 877 ✔️ 288 💤 0

Results for commit 10ed66b.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2652 (10ed66b) into 5.6.x (ac90b09) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            5.6.x    #2652      +/-   ##
==========================================
- Coverage   54.02%   53.99%   -0.04%     
==========================================
  Files         558      558              
  Lines       40630    40630              
==========================================
- Hits        21952    21939      -13     
- Misses      18678    18691      +13     
Files Changed Coverage Δ
python/nav/models/profiles.py 69.53% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johannaengland johannaengland changed the title Log refusing to send alerts to blacklisted addresses as debug instead of warning Log refusing to send alerts to addresses of blacklisted types as debug instead of warning Aug 8, 2023
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough.. now it's just a matter of writing/solving all the other issues that are discussed and found in #1787 :)

@johannaengland johannaengland merged commit 18c6ffe into Uninett:5.6.x Aug 9, 2023
10 of 12 checks passed
@johannaengland johannaengland deleted the log-blacklisted-addresses-debug branch August 9, 2023 08:29
@johannaengland johannaengland linked an issue Aug 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsendable alerts are logged on every alertengine queue check
3 participants