Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate slack address in alert addresses #2657

Merged
merged 2 commits into from Aug 16, 2023

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Aug 10, 2023

Just one of the many incoming alert engine tasks sparked by #1787.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2657 (4afe04c) into 5.6.x (83095e7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 4afe04c differs from pull request most recent head 9aac97f. Consider uploading reports for the commit 9aac97f to get more accurate results

@@            Coverage Diff             @@
##            5.6.x    #2657      +/-   ##
==========================================
+ Coverage   54.04%   54.13%   +0.08%     
==========================================
  Files         558      558              
  Lines       40630    40641      +11     
==========================================
+ Hits        21958    22000      +42     
+ Misses      18672    18641      -31     
Files Changed Coverage Δ
...on/nav/alertengine/dispatchers/slack_dispatcher.py 51.06% <100.00%> (+11.06%) ⬆️
python/nav/web/alertprofiles/forms.py 55.78% <100.00%> (+5.78%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Test results

     12 files       12 suites   11m 14s ⏱️
3 236 tests 3 140 ✔️   96 💤 0
9 183 runs  8 895 ✔️ 288 💤 0

Results for commit 9aac97f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, doc-improvement,otherwise ok.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, agree with Hanne's nitpick :)

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johannaengland johannaengland merged commit 2831b68 into Uninett:5.6.x Aug 16, 2023
11 checks passed
@johannaengland johannaengland deleted the validate-slack-address branch August 16, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants