New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate slack address in alert addresses #2657
Validate slack address in alert addresses #2657
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.6.x #2657 +/- ##
==========================================
+ Coverage 54.04% 54.13% +0.08%
==========================================
Files 558 558
Lines 40630 40641 +11
==========================================
+ Hits 21958 22000 +42
+ Misses 18672 18641 -31
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, doc-improvement,otherwise ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, agree with Hanne's nitpick :)
4afe04c
to
9aac97f
Compare
Kudos, SonarCloud Quality Gate passed! |
Just one of the many incoming alert engine tasks sparked by #1787.