Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PoE config for Juniper devices #2666

Merged
merged 25 commits into from Nov 15, 2023
Merged

Add PoE config for Juniper devices #2666

merged 25 commits into from Nov 15, 2023

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Aug 28, 2023

Fixes #2633

Adds backend for getting current state for juniper interfaces and changing the state

I will add more /better tests

also the code smells will be fixed..

@stveit stveit self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2666 (e9cf952) into master (e879e67) will decrease coverage by 0.05%.
Report is 4 commits behind head on master.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
- Coverage   55.19%   55.14%   -0.05%     
==========================================
  Files         561      561              
  Lines       40917    40983      +66     
==========================================
+ Hits        22584    22602      +18     
- Misses      18333    18381      +48     
Files Coverage Δ
python/nav/portadmin/handlers.py 46.49% <100.00%> (+1.44%) ⬆️
python/nav/portadmin/napalm/juniper.py 40.95% <23.80%> (-4.94%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Test results

     12 files       12 suites   13m 10s ⏱️
3 239 tests 3 239 ✔️ 0 💤 0
9 192 runs  9 192 ✔️ 0 💤 0

Results for commit 9659a76.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have much to pick on here, except for the obvious duplicates of #2635 (moving around of test fixtures, and adding new exception classes)

python/nav/portadmin/handlers.py Outdated Show resolved Hide resolved
python/nav/portadmin/napalm/juniper.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stveit stveit marked this pull request as ready for review November 6, 2023 16:58
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Looking forward to testing against actual equipment :)

@stveit stveit merged commit bb794f2 into Uninett:master Nov 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure PoE for Juniper equipment
2 participants