Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect load average object names #2672

Merged
merged 1 commit into from Sep 1, 2023
Merged

Fix incorrect load average object names #2672

merged 1 commit into from Sep 1, 2023

Conversation

lunkwill42
Copy link
Member

Fixes #2671

@lunkwill42 lunkwill42 self-assigned this Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited

Codecov Report

Merging #2672 (7b60a35) into 5.6.x (2831b68) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            5.6.x    #2672   +/-   ##
=======================================
  Coverage   54.13%   54.13%           
=======================================
  Files         558      558           
  Lines       40641    40641           
=======================================
  Hits        22000    22000           
  Misses      18641    18641
Files Changed Coverage Δ
python/nav/mibs/juniper_mib.py 48.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Test results

     12 files       12 suites   12m 3s ⏱️
3 234 tests 3 138 ✔️   96 💤 0 ❌
9 177 runs  8 889 ✔️ 288 💤 0 ❌

Results for commit 7b60a35.

johannaengland
johannaengland approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we had some tests for that as well 😁

@lunkwill42
Copy link
Member Author

Would be nice if we had some tests for that as well 😁

Agreed, put an issue on the pile 😆

@lunkwill42 lunkwill42 merged commit 45c26ca into Uninett:5.6.x Sep 1, 2023
12 checks passed
@lunkwill42 lunkwill42 deleted the bugfix/juniper-loadavg-incorrect branch September 1, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannaengland johannaengland johannaengland approved these changes

Assignees

@lunkwill42 lunkwill42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lunkwill42 @johannaengland