Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate checkpoint VLAN interfaces with VLANs #2701

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #2684.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the point :)

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2701 (fc4402b) into master (e879e67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2701   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files         561      561           
  Lines       40917    40917           
=======================================
  Hits        22584    22584           
  Misses      18333    18333           
Files Coverage Δ
python/nav/ipdevpoll/plugins/prefix.py 45.80% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

github-actions bot commented Nov 1, 2023

Test results

     12 files       12 suites   14m 48s ⏱️
3 218 tests 3 218 ✔️ 0 💤 0
9 129 runs  9 129 ✔️ 0 💤 0

Results for commit fc4402b.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit a5d5319 into Uninett:master Nov 1, 2023
13 checks passed
@johannaengland johannaengland deleted the vlan-patterns-checkpoint branch November 1, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint VLAN interfaces are not properly associated with their VLANs
2 participants