Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to bin/navuser to remove user #2705

Merged
merged 2 commits into from Nov 2, 2023
Merged

Add command to bin/navuser to remove user #2705

merged 2 commits into from Nov 2, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 2, 2023

No description provided.

@hmpf hmpf added the useradmin label Nov 2, 2023
@hmpf hmpf self-assigned this Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited

Codecov Report

Merging #2705 (7237b0c) into master (e879e67) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   55.19%   55.19%           
=======================================
  Files         561      561           
  Lines       40917    40917           
=======================================
  Hits        22584    22584           
  Misses      18333    18333

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited

Test results

     12 files       12 suites   13m 40s ⏱️
3 218 tests 3 218 ✔️ 0 💤 0 ❌
9 129 runs  9 129 ✔️ 0 💤 0 ❌

Results for commit 7237b0c.

♻️ This comment has been updated with latest results.

johannaengland
johannaengland requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for double error handling everything works as expected.

bin/navuser Outdated Show resolved Hide resolved
lunkwill42
lunkwill42 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition :) Nothing to add besides Johanna's valid comment.

@hmpf @johannaengland
Remove unneccessary error-handling
7237b0c 
Co-authored-by: Johanna England <johanna.england@sikt.no>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

johannaengland
johannaengland approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hmpf hmpf merged commit 1b3b04e into Uninett:master Nov 2, 2023
13 checks passed
@hmpf hmpf deleted the navuser-remove branch November 6, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@johannaengland johannaengland johannaengland approved these changes

@stveit stveit Awaiting requested review from stveit

Assignees

@hmpf hmpf

Labels
useradmin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hmpf @lunkwill42 @johannaengland