Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for automatic creation of remote users #2707

Merged
merged 2 commits into from Nov 13, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 2, 2023

Add a new flag to the remote user config that by default is off. If remote users is enabled and the new flag is toggled on, the username in REMOTE_USER will be used to automatically create a new user with that username. Automatic creation regardless used to be the default behavior.

Because the default behavior for remote users has changed this needs to be flagged well in NOTES.

Depends on #2706.

For https://github.com/Uninett/campus-tasks/issues/22

@hmpf hmpf requested a review from lunkwill42 November 2, 2023 12:57
@hmpf hmpf self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2707 (5bcd7bb) into master (3ceacf5) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
- Coverage   55.22%   55.22%   -0.01%     
==========================================
  Files         565      565              
  Lines       40945    40950       +5     
==========================================
+ Hits        22612    22613       +1     
- Misses      18333    18337       +4     
Files Coverage Δ
python/nav/web/auth/remote_user.py 70.00% <8.33%> (-2.39%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 2, 2023

Test results

     12 files       12 suites   12m 4s ⏱️
3 221 tests 3 221 ✔️ 0 💤 0
9 138 runs  9 138 ✔️ 0 💤 0

Results for commit 5bcd7bb.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the toggle-remote-user-creation branch 2 times, most recently from a58d417 to a2dcea3 Compare November 6, 2023 07:47
Add a new flag to the remote user config that by default is off. If
remote users is enabled and the new flag is toggled on, the username in
REMOTE_USER will be used to automatically create a new user with that
username. Automatic creation regardless used to be the default behavior.
@hmpf hmpf force-pushed the toggle-remote-user-creation branch from a2dcea3 to 1066719 Compare November 10, 2023 10:27
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hmpf hmpf merged commit 7d71130 into Uninett:master Nov 13, 2023
11 of 13 checks passed
@hmpf hmpf deleted the toggle-remote-user-creation branch November 14, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants